Don't compile ModuleProxyFactory, and don't deploy it any longer #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ModuleProxyFactoryis deployed by the Zodiac team, to many many networks. We don't need to be deploying our own instance of it.The real reason for this change is a very deep rabbit hole of solidity bytecode mismatch when using multiple version of solidity in the project (which, at the time of this PR, doesn't exist, but other open branches need to use solidity 0.8.22, and when I do that, for SOME DANG REASON I cannot for the life of me get the deployment scripts to NOT re-deploy this
ModuleProxyFactorycontract).So anyway, let's just not deploy it any more ever again :) That'll solve my problems in the other branches.